search

SilverAndro / RPGStats

A stats mod for quilt servers
Mozilla Public License 2.0
40 stars 17 forks source link

Ancient Debris doesn't grant Mining XP on 1.17 #63

Open Neubulae opened 3 years ago

Neubulae commented 3 years ago

So are deepslate ores, bruh

SilverAndro commented 3 years ago

Hm the deepslate versions should be falling back to the default 2 xp

SilverAndro commented 3 years ago

Can you check if both of these are still issues in 4.1.5? (And if they are can you enable the new debug messages and show the log?)

Neubulae commented 3 years ago

Seems like Deepslate Gold Ore and Ancient Debris still don't work? Diamond ore works now tho, haven't check others

SilverAndro commented 3 years ago

Well deepslate gold and ancient debris are both specified here, do you have the debug logs?

Neubulae commented 3 years ago

图片 This was shown in console, but in reality my stats didn't go up as I checked my stats thru /rpgstats

SilverAndro commented 3 years ago

Hm that's quite strange Only thing I can think of is something messing with my CCA component, would a mod list be possible?

Neubulae commented 3 years ago

mods.txt ignore the files ending in disabled

SilverAndro commented 3 years ago

Alright thanks, ill look into this

Neubulae commented 3 years ago

I raised priority of RPGStats' mixins to 50 and the issue disappeared. I suppose this is due to mixin conflicts?

SilverAndro commented 3 years ago

Shoudn't be, that runs off the block break event (PlayerBlockBreakEvents.AFTER) 🤔

Neubulae commented 3 years ago

Shoudn't be, that runs off the block break event (PlayerBlockBreakEvents.AFTER) thinking

huh.

SilverAndro commented 3 years ago

Getting a chance to poke at this more, this is very strange

Your definitely getting the XP, so its failing to save for some reason, but why only for mining? Why only specific blocks?

My first thought would be with upgradeStatDataTov2, but that affects all stats, and CCA drops the data afterwards so its not that

Haven't had a chance to go though the modlist yet, but I guess thats my next step

Neubulae commented 3 years ago

Getting a chance to poke at this more, this is very strange

Your definitely getting the XP, so its failing to save for some reason, but why only for mining? Why only specific blocks?

My first thought would be with upgradeStatDataTov2, but that affects all stats, and CCA drops the data afterwards so its not that

Haven't had a chance to go though the modlist yet, but I guess thats my next step

I changed mixin priority and worked, would that give any clue? maybe somebody @Redirected…

SilverAndro commented 3 years ago

Dont know, I'll just have to put in the work to get everything downloaded

Neubulae commented 3 years ago

After some testing I found out this problem being much weirder than expected: I said it's working, right? No. It only works around half the time. I can dig up one debris while receiving no XP, and yet I dig another one that grants me XP. By placing down and digging up, I receive XP only around 50% of the time. This is getting concerning.

chronosacaria commented 2 years ago

@Neubulae If I had to guess, it looks like there might be some server issues with GeyserMC. Whilst you did say you found out what the issue was, in the end, insomuch as you were receiving XP ~50% of the time (this is intentional), I am thinking that there were some conflicts that were happening between GeyserMC and RPGStats with respect to priority.

I would imagine that GeyserMC would need to maintain the highest priority in order to keep the clients in sync which would mess with other mods (only a theory), but if I had to put money on it, I would say that is where the issue is probably coming from