search

SilverAndro / RPGStats

A stats mod for quilt servers
Mozilla Public License 2.0
40 stars 17 forks source link

Mods that would be nice if they were connected to their tools. #90

Closed ColdDead closed 2 years ago

ColdDead commented 2 years ago

It would be nice if the following mods are made compatible. You can also use the tools lvl to run the rpg system. Mods: Harvest Scythes Artifality

SilverAndro commented 2 years ago

Harvest scythes already has compat?

ColdDead commented 2 years ago

I use the harvest scythes and i get not xp for the harvesting

SilverAndro commented 2 years ago

Could you enable the debug xp log and share that?

ColdDead commented 2 years ago

Can i client side enable it? Is a public server

SilverAndro commented 2 years ago

No the server does absolutely everything

SilverAndro commented 2 years ago

Found the bug with harvest scythes, ill fix that

SilverAndro commented 2 years ago

What exactly should get compat with Artifality? I don't see anything obvious on their wiki

ColdDead commented 2 years ago

They have tools for example the scythe with which you can boost plants with bone meal + harvest you still get a bit of xp but no rpg lvl even though you harvest the plant

Kluzzio commented 2 years ago

https://github.com/PinkGoosik/artifality/blob/1.18-fabric/src/main/java/artifality/item/HarvestStaffItem.java#L39 Artifality is slightly lazy with how this part is implemented. If this one part was changed to handle the breaking of the crop similarly to how SimpleHarvest is done, a simple mixin could handle the functionality here.

Kluzzio commented 2 years ago

RPGStats currently does make an exception for SimpleHarvest but the point is that the implementation in artifality should not be completely devoid of reference to the player in the replanting of the crop.

Kluzzio commented 2 years ago

Artifality compat is now implemented