search

SilverEzhik / mpv-msix

mpv packaged for Windows 10
https://www.microsoft.com/store/productId/9P3JFR0CLLL6
GNU Affero General Public License v3.0
51 stars 3 forks source link

mpv starts terminal session when launched from syncplay #18

Open soredake opened 8 months ago

soredake commented 8 months ago

To reproduce: 1) Download mpv from microsoft store 2) Install this build of syncplay https://mega.nz/file/IRRCjAhQ#rCXXHHVbQUa_B4jBuk4cQLafvQKnhmwFlDqmFaxImlU 3) Configure syncplay to use mpv from microsoft store 4) Join any room. 5) You will see this: image

SilverEzhik commented 8 months ago

Unfortunately not familiar with syncplay or how it uses mpv. Given that the mpv.exe available from the command line is using the mpv console launcher, it might end up launching with a command line window. You can consider using the mpv URL scheme to work around this.

soredake commented 8 months ago

You can consider using the mpv URL scheme to work around this.

Not really possible with syncplay.

SilverEzhik commented 8 months ago

Does it not work at all, or is the main issue that it shows a command line window? If it's the second, it's a common Windows annoyance with command line apps (the whole point of mpv-console-launcher is to have an mpv CLI on Windows), so I'm not sure what a good workaround would be. Unfortunately unable to test this myself as I don't currently have a working Windows development machine.

soredake commented 8 months ago

or is the main issue that it shows a command line window?

This.

If it's the second, it's a common Windows annoyance with command line apps (the whole point of mpv-console-launcher is to have an mpv CLI on Windows), so I'm not sure what a good workaround would be.

Perhaps you can look at mpv.net software, it had Microsoft store build (until 6.0.4.0-stable version) and had mpvnet.com binary that started from syncplay without terminal session.

Et0h commented 8 months ago

I just tested on Windows 10 and it shows a terminal window when running mpv via Syncplay even with --no-terminal command line option is set. I do not have this issue when running the non-Windows Store version of mpv or the Windows store version of mpv.net. I tried running mpv-console-launcher.exe directly but got an access denied error.