SilverLabUCL / PySilverLabNWB

Python tools for working with Silver Lab data in the NWB2 format
MIT License
1 stars 0 forks source link

Add custom extensions #18

Closed alessandrofelder closed 4 years ago

ageorgou commented 4 years ago

As far as I can see, the test failures are:

  1. pep8 style check
  2. epochs test because of recent API change; for this PR, I think we should fix pynwb to 1.1.2, and then make the necessary update in #11.
  3. epochs test because of a numpy problem? (only in some jobs, like this one!) We should verify what version we use locally.

The signatures tests are skipped. I examined @alessandrofelder's results manually (eliminating expected or previously checked discrepancies due to renaming, precision changes etc), and it generally looks okay, except for the following:

The only other big thing that has changed is the structure of the ImageSegmentation processing module. I believe we check that through Matlab, though?

A few other minor things are due to schema changs (missing decriptions, experimenter and related publications are now vectors).

alessandrofelder commented 4 years ago

Great, some comments:

See this commit on AnalysisPipeline repo for programmatical checks

ageorgou commented 4 years ago

My mistake - timestamps_reference_time comes from pynwb, presumably added since NWB1.

codecov-io commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (adapt-to-updated-libs@56e6ce6). Click here to learn what that means. The diff coverage is 14.28%.

Impacted file tree graph

@@                   Coverage Diff                   @@
##             adapt-to-updated-libs     #18   +/-   ##
=======================================================
  Coverage                         ?   25.9%           
=======================================================
  Files                            ?      12           
  Lines                            ?    1490           
  Branches                         ?     240           
=======================================================
  Hits                             ?     386           
  Misses                           ?    1086           
  Partials                         ?      18
Impacted Files Coverage Δ
src/silverlabnwb/generate_extended_schema.py 0% <0%> (ø)
src/silverlabnwb/nwb_file.py 38.99% <30.76%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 56e6ce6...41ff515. Read the comment docs.

ageorgou commented 4 years ago

@alessandrofelder If you don't have any comments about my changes, I think we can merge this now.

alessandrofelder commented 4 years ago

No further comments, thanks for reviewing!