SilverLabUCL / PySilverLabNWB

Python tools for working with Silver Lab data in the NWB2 format
MIT License
1 stars 0 forks source link

Update signatures for NWB2 #22

Closed ageorgou closed 4 years ago

ageorgou commented 4 years ago

Will fix #8.

codecov-io commented 4 years ago

Codecov Report

Merging #22 into adapt-to-updated-libs will increase coverage by 23.65%. The diff coverage is 66.66%.

Impacted file tree graph

@@                    Coverage Diff                     @@
##           adapt-to-updated-libs      #22       +/-   ##
==========================================================
+ Coverage                   25.9%   49.56%   +23.65%     
==========================================================
  Files                         12       12               
  Lines                       1490     1491        +1     
  Branches                     240      241        +1     
==========================================================
+ Hits                         386      739      +353     
+ Misses                      1086      724      -362     
- Partials                      18       28       +10
Impacted Files Coverage Δ
tests/test_labview_import.py 74.46% <ø> (+30.71%) :arrow_up:
src/silverlabnwb/signature.py 55.45% <66.66%> (+38.02%) :arrow_up:
src/silverlabnwb/nwb_file.py 92.45% <0%> (+53.45%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f43346b...1576a72. Read the comment docs.

alessandrofelder commented 4 years ago

I haven't got the full Labview folder for 170317_10_11_01 or 170322_14_06_43 to regenerate their signatures from scratch...

ageorgou commented 4 years ago

The signature file161215_15_34_21.sig2 is missing the section on the EyeCam acquisition because I didn't have the data locally! I only realised this belatedly, and to keep things from getting too confusing (more work has been done since then), I suggest adding this back in a new PR.

Assuming that, this is ready for review!

ageorgou commented 4 years ago

The files are useful for checking a variety of different input data, especially since we don't have many unit tests. We could be more selective, although if they don't take too long to run it doesn't hurt to have more!