search

SilverLabUCL / PySilverLabNWB

Python tools for working with Silver Lab data in the NWB2 format
MIT License
1 stars 0 forks source link

Improve compression #31

Closed alessandrofelder closed 4 years ago

alessandrofelder commented 4 years ago

manifold compression reduces file size a lot more than our previous NWB2 compression efforts. This PR also adds option for users to facultatively disable compression - it is enabled by default - via the import_labview_folder method but not sure this is the most elegant way to do it

codecov-io commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@72417e7). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #31   +/-   ##
=========================================
  Coverage          ?   50.19%           
=========================================
  Files             ?       12           
  Lines             ?     1526           
  Branches          ?      251           
=========================================
  Hits              ?      766           
  Misses            ?      729           
  Partials          ?       31

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 72417e7...8c4aade. Read the comment docs.

ageorgou commented 4 years ago

Also tried it on all the data I had access to and noticed a big reduction!