SilverLabUCL / PySilverLabNWB

Python tools for working with Silver Lab data in the NWB2 format
MIT License
1 stars 0 forks source link

Delay parsing trial times #34

Closed ageorgou closed 4 years ago

ageorgou commented 4 years ago

Addressing a TODO comment from earlier version. At the moment we only have tab-separated lines in the Intertrial FIFO Times section (the trigger times indicating beginning and end of trials) so we may not need the extra generalisation this gives. Even so, this moves the parsing of those lines to the relevant place and keeps the original text (without any casting) in the raw fields.

ageorgou commented 4 years ago

Will not merge until #35 is done, so we have some tests.

codecov-io commented 4 years ago

Codecov Report

Merging #34 into new-labview will decrease coverage by 1.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           new-labview      #34      +/-   ##
===============================================
- Coverage        54.88%   53.84%   -1.04%     
===============================================
  Files               14       15       +1     
  Lines             1629     1690      +61     
  Branches           254      265      +11     
===============================================
+ Hits               894      910      +16     
- Misses             698      743      +45     
  Partials            37       37              
Impacted Files Coverage Δ
src/silverlabnwb/header.py 87.12% <100.00%> (+1.40%) :arrow_up:
src/silverlabnwb/metadata_gui.py 0.00% <0.00%> (ø)
src/silverlabnwb/nwb_util.py 0.00% <0.00%> (ø)
src/silverlabnwb/metadata.py 88.63% <0.00%> (+0.26%) :arrow_up:
src/silverlabnwb/signature.py 57.89% <0.00%> (+0.34%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a03b70f...e765e46. Read the comment docs.