SilverLabUCL / PySilverLabNWB

Python tools for working with Silver Lab data in the NWB2 format
MIT License
1 stars 0 forks source link

Minor tweaks to metadata loading #52

Open pgleeson opened 4 years ago

pgleeson commented 4 years ago

Generating an nwb file from metadata.yml works fine locally. Some minor suggestions:

ageorgou commented 4 years ago

Thanks for the feedback @pgleeson, we'll look into the error message and instructions.

You're right that the ORCID etc is not used currently. I don't see a place for it specifically in the standard NWB schema, although it may have been possible to add it in NWB1. Would it make sense to store it alongside the name under experimenter in the NWB file? In any case, it's not required at the moment, so omitting it from the metadata file should not cause any problems.

As for the editor, we'll have to think it through a bit as it's a different workflow than the one originally imagined. It currently assumes that there can only be one custom metadata file, created by the editor and stored in the user's local configuration directory. It relies on reading the "base" metadata file that comes with the package in order to create the GUI, then optionally the local file to add or override any settings. If we allow the editor to load and edit any file (which makes sense), we'll have to make sure it first loads all settings correctly.

pgleeson commented 4 years ago

Re ORCID, yes, a url in brackets coud be generated beside the name.

It's not urgent re the GUI, the main use case in the short term is a simple human editable text file to give to people to edit. Good to bear in mind the use case of editing/saving any standalone metadata file though.