SilverLabUCL / PySilverLabNWB

Python tools for working with Silver Lab data in the NWB2 format

MIT License

1 stars 0 forks source link

stop wheel from building for python 2 #57

Closed alessandrofelder closed 4 years ago

alessandrofelder commented 4 years ago

The reason for our distribution looking like it was being built for python 2 despite us removing support was a setting in setup.cfg. See https://wheel.readthedocs.io/en/stable/quickstart.html.

I have tested that this avoids py2 in the file that wheel creates. I assume this means this removes any trace of Python 2. Python 2 was never listed as a supported programming language for the PyPI package, see https://test.pypi.org/project/silverlabnwb/0.1.0/.

codecov-commenter commented 4 years ago

Codecov Report

Merging #57 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #57   +/-   ##
=======================================
  Coverage   53.69%   53.69%           
=======================================
  Files          12       12           
  Lines        1583     1583           
  Branches      253      253           
=======================================
  Hits          850      850           
  Misses        697      697           
  Partials       36       36

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fef8824...daa3615. Read the comment docs.

ageorgou commented 4 years ago

Good catch! Have you confirmed that the wheel produced with this is only marked for Python 3?

alessandrofelder commented 4 years ago

Yes!

The difference is that there is only Tag: py3-none-any instead of

Tag: py2-none-any
Tag: py3-none-any

in one of the wheel info files, and the .whl file is named differently.