Silverfeelin / SkyGame-Planner

Sky:CotL unlock planner/tracker
Other
28 stars 4 forks source link

Unlock Cost Calculator improvements #151

Closed jxj3699 closed 2 months ago

jxj3699 commented 3 months ago

Search

I wrote everything below and then I started on search filters and realized it can replace a lot of the stuff below (and the search bar is already there) so I moved it to the top.

Similar idea (in the sense of using whats already there), copy the catalogue from Items since it has a few of the important filters already (show owned, missing, favourites, limited). And when an item is selected, instead of directing to the item page, it would add it to the calculator.

General

Favorites

Seasons

Realm Constellations

Silverfeelin commented 3 months ago

Hey, I'll have a more detailed look at your suggestions and respond to your ideas when I have more time. If you want to, you can adjust your feedback based on this since some problems might no longer be relevant!

For now, I'll share this. I kind of just repurposed the search bar from the dashboard for the calculator to save some time. I'm working on improved item filters for the items page. I want to include this same list (with filters) to the calculator page, replacing the current search bar. These filters are only applied when you click on the filter icon and they'll save to your browser.

You can see the WIP version here: https://p-item-filters.sky-planner.pages.dev/item

image

One thing I'm still unsure about is handling item types. I'm not a fan of "mixing" multiple item types together in one list, so the item type filter is still at the top of the page separate from these new detailed filters. If you have any ideas on that I'd love to hear them!

image

image

Also, this may be a little counterintuitive at first but as soon as you check one season/event/realm it will hide all other seasons/events/realms that you haven't also checked. But if you haven't checked any of them then it will show all. It's a compromise to make it easier to filter by one season than to have to deselect all of the other ones.

image

image

image

jxj3699 commented 3 months ago

Hey, since you're already working on improving the item page filters and then plan to use the same setup for the calculator, you've addressed most, if not all, of the things I suggested regarding item organization.

Updated Calculator Feedback

There's a few things I'd like for the calculator. I mentioned a couple of these things in the original comment, but I'll include them here for clarity.

WIP Filter Feedback

I checked out the WIP version, and I like the filtering. Thanks for sharing it.

When filtering, I found it easier to understand when I checked all as negative then went and changed all the ones I wanted to positive. Its the same as only checking the ones I want but I like the visual.

Additions/Improvements:

Mixing Items

Since you asked, I do have a few thoughts about mixing items. For perspective, I exclusively use the planner on my phone. I didn't even know I could use it on my computer until the other day. A tad silly because it is a website lol.

Anyway, I can't see the item types when I'm filtering, and if I'm just looking for a specific item that I know is a prop, I have to scroll back up and go through each prop category after setting the filters. However, if I know I'm looking for any season outfit or mask, then having one selected is good. So, I think adding an option to disable it and select multiple (or all) would be good.

Looking at both options, I'd like to keep the item types in their own section. However, I don't know if the item type filter has to go with the rest of the filters to work for multiple selection, but it would be cluttered. It would have to go under a dropdown like the other filters.

I don't know much about coding, so correct me if I'm wrong, but having the item types at the top (separate) is like the main filter/branch, then the additional filters make little branches from that. So if the item types stayed where they are and multiple were selected, it would be like holding separate branches and asking them all to follow the same path, and I don't know if that's possible or more work than it's worth.

Silverfeelin commented 3 months ago

Lots of changes have been made to the preview at https://p-item-filters.sky-planner.pages.dev/ Let's have a look.

Items

Calculator

Other

image image image image image image

TODO

Silverfeelin commented 3 months ago

@jxj3699 Let me know if you have feedback for the current version. I've incorporated a bunch of changes based on your feedback!

jxj3699 commented 3 months ago

Oh my gosh, it's awesome. I love it! Thank youuu

Yay, music sheets! So many filter options, adding starter and unsorted is brilliant. I love how you handled currencies. Changing the unchecked or checked to on and off is great. The "All" or "None" labels with the updated colour changes are perfect. Adding and shortening the names of seasons and events is perfect. The events are much easier to view on mobile. I like being directed to the selected items page. I like how on mobile it opens a new window within the app page rather than redirecting to the browser. For spirit trees in the breakdown, I like that it shows the cost of just the selected items (and required blessings and wing buff) rather than everything. Being able to search by spirit, event, or item is more than enough, so selecting multiple item types isn't needed. I like being redirected to the calculator with the selected items from outfit request.

Feedback

I'm so excited for this to be added to the live version. Thank you again.

Silverfeelin commented 3 months ago

me rn image

jxj3699 commented 3 months ago

me rn image

Lol 😂

Silverfeelin commented 2 months ago

I've released the improved item filters and unlock calculcator. Any further suggestions are welcome in new issues. Thanks for all your feedback! I have also added a few recent names including yours to the credits page.

jxj3699 commented 2 months ago

@Silverfeelin It's awesome!!! Thank you so much 🩷🩷🩷