SilverlineDev / bizhawk

Automatically exported from code.google.com/p/bizhawk
0 stars 0 forks source link

UI issues with high DPI displays #353

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I'm running Windows 8.1 on a MacBook Pro Retina 13" (2560x1600).  Windows DPI 
scaling is enabled at 175%.  For the most part BizHawk works fine, but there 
are some places where the UI controls are not sized optimally and the text gets 
cut off.

I've attached some screenshots to show some examples where this happens.  The 
left side is from the BizHawk 1.9.1 release, and the right side is from a 
modified build where I've fixed the issues.

I will add a comment containing the patch and some explanation.

Original issue reported on code.google.com by jdpurcell on 28 Dec 2014 at 1:34

Attachments:

GoogleCodeExporter commented 9 years ago
Summary of changes:
1) I set AutoScaleMode to Font on a few forms that were missing it (most were 
already set to Font already).
2) I set AutoScaleMode to Inherit on some UserControls.  I would recommend 
setting it to Inherit on all UserControls, but I only changed it on the 
affected controls to minimize the size of the patch.  I think there's a bug in 
.NET's auto scaling and it doesn't like controls anchored to the bottom and/or 
right of UserControls with AutoScaleMode=Font.
3) When dynamically creating controls, .NET does not take care of the scaling 
automatically. I fixed any code like this to adjust the control locations/sizes 
appropriately.

Original comment by jdpurcell on 28 Dec 2014 at 1:56

Attachments:

GoogleCodeExporter commented 9 years ago
I've added you to the project with committer privledges.  Feel free to make any 
high DPI changes you like, so long as they're tested and don't regress the 
standard 96dpi setting.

Original comment by goyu...@gmail.com on 28 Dec 2014 at 5:59

GoogleCodeExporter commented 9 years ago
Okay I've committed my changes. That should fix all of the scaling issues that 
I found with the exception of some things in the Virtual Pad (e.g. the analog 
stick). Hopefully I will have time to revisit that but at least for now it's 
better than it was :).

Original comment by jdpurcell on 29 Dec 2014 at 12:03

GoogleCodeExporter commented 9 years ago
I fixed up some more things in the Virtual Pad. Now only the Target Screen 
(e.g. NES Zapper) isn't scaled because when I tried it, it affected the X / Y 
range. I'll see if I can figure that out later.

Original comment by jdpurcell on 31 Dec 2014 at 5:40

GoogleCodeExporter commented 9 years ago
Scaling of target screen has been improved. I'm reasonably happy with how all 
of the scaling works now; marking as fixed.

Original comment by jdpurcell on 1 Jan 2015 at 10:28