Silverpop / engage-api-client

Engage API Client Code
Apache License 2.0
13 stars 24 forks source link

Infinite loop of logout command if session is expired #20

Open rkovarik opened 9 years ago

ergin-a1 commented 7 years ago

Can someone please merge the fixes or provide update about this? IMHO, this is a high priority bug and makes the whole code unusable. I am also open to other workaround to overcome this issue temporarily.

ChrisCurtin commented 7 years ago

@ergin-a1

Hi Ergin,

We've not done any work on this in quite a while. Looking through the pulls that we didn't accept last time we did, I don't see one that only had this fix it in so it won't be a simple accept of an existing pull.

It looks like rkovarik had the right idea here: https://github.com/rkovarik/engage-api-client/commit/237d5b6ccd70666a6150ccee1f76a5b28d5fcfae

If you want to fork develop, add this and run a test then submit a pull with just that change I'll see who can help test it and accept it.

Thanks

Chris