Refactor

[micolous]

This is a pretty large pull request, but this is also a pretty major refactoring:

• Adds some unit tests.
• Adds type annotations, now passes pytype.
• Baseline profile is now retained throughout the simulation process, even if it doesn't perform as well as the permutations (like raidbots).
• Differences for permuted profiles are tracked, so you can easily see what was different about Profile_0004.
• Fix some issues with quoted profile names.
• Remove T27 checks, and support for Tier items. I don't think tier items work this way any more, so it's just confusing.
• Remove a large amount of global variables.
• Ignore and remove Shard of Oth and Shard of Rev's fake enchants – these will be added by SimulationCraft if needed.
• Include augmentation and temporary_enchant when splitting profiles.
• Fix update_language_file.py to work on non-Windows platforms, and force it to be UTF-8.
• Removed translation support for command-line flags. This is uncommon – and prone to automation errors. The help text for the flags is still translated.
• Fixes some spelling and grammar errors. Most commonly permutate -> permute.
• Removed a lot of duplicated code.
• fights: new module, absorbs data from fight_types.json.
  • Fights are no longer prefixed with Default_ (ie: Default_Patchwerk is now Patchwerk).
  • Removed old TMI_T21N25 fight (which was for T21).
  • Fixed syntax errors for "Two Patchwerks, 27 yards away from each other" fight.
  • Fight descriptions are now translatable.
• main.py is now less than half of the original size, much of its functionality has been split into other modules:
  • i18n: new module, absorbs all i18n stuff from main.py.
  • item: new module, absorbs items and weapons related stuff from main.py.
  • permutation: new module, mostly rewrote the permutation engine to make things simpler.
  • profile: new module:
  • PermutationData -> EquipmentLoadout
  • Profile: Rewrite of AddonImporter
  • Now tested using SimulationCraft's T27 profiles; I found and fixed some parser bugs as a result.
  • simc: update manager, mostly rewritten to handle things in a more structured way, and avoid as many requests
• settings:
  • Removed additional_input_file: this didn't do what the comment stated, and was instead overwritten when running a custom fight.
  • Removed default_equip_t27_min, default_equip_t27_max: Removed when removing T27.
  • Removed file_fightstyle: this is now part of fights.py.
  • Removed temporary_folder_basepath, clean_up, delete_temp_default: temporary directories are now handled using Python's standard library
• specdata: rewrite / simplification.

Coverage data; this does not show all files, but this is starting from 0! 😄

Name             Stmts   Miss  Cover
------------------------------------
fights.py           34      0   100%
i18n.py             48     15    69%
item.py            159     21    87%
permutation.py      69      7    90%
profile.py         250     26    90%
simc.py            111     48    57%
specdata.py         68     32    53%
utils.py            16      6    62%
------------------------------------
TOTAL              755    155    79%

TODO list:

• Get CI working

[scamille]

Thanks for all the great work. Also thanks for providing such a detailed breakdown of the changes here in the pull request.

I had a quick glance over it, and it looks great so far. I want to take a deeper look at profile.py and permutation.py, since I am responsible for most of the previous rewrite of that code and am just curious of the changes there. I also want to run some simulations based on your branch to see if I run into any problems.

Can you please check which minimum python version is required for your changes? The Readme still lists 3.5, but that might need to be upgraded with all the new stuff you used, which at least I don't remember being available when working with python all those years ago.

~One thing which could also be done for the rewrite is to completely separate the nightly auto-download into a separate file while you are at it, might make main.py even smaller.~

In any case, great work and I hope we can get this merged soon. Even if there are still some minor problems, it can't be worse than the stale, nearly rotten state that AutoSimc is in right now :)

[scamille]

Ok I was able to take a look at it. Great work, runs fine and is much more organized.

[scamille]

If possible, please rebase on top of the current master. I think you might have already have incorporated my last 2 commits, if so you can just discard the incoming changes.