SimCMinMax / WoW-BugTracker

Unofficial/Community Issue Tracker for current versions of World of Warcraft.
27 stars 6 forks source link

Last Surprise deals less damage than intended (used to be more) #357

Closed Melekus closed 6 years ago

Melekus commented 6 years ago

Game Version:

8.0.1 Beta Build 27547

Description:

The Unholy Death Knight Azerite trait deals more damage than intended.

Details:

Last Surprise is a shadow damage aoe that triggers on army of the dead ghoul death. The damage is flagged in the spell data to be affected by Mastery: Dreadblade and by the Unholy Death Knight global damage aura (-12%). But in reality, it seems to be affected by those effects twice.

My theory is that since the damage is attributed to the pet in the combatlog, it's also affected by the global pet damage multiplier (equal to to global damage aura of -12%) and by the same mechanic that makes Pet shadow damage (such as gargoyle strike or sweeping claws) scale with mastery without manually flagging them.

Logs, Images, Videos

Spreadsheet comparing ingame damage and the expected formula: https://docs.google.com/spreadsheets/d/1z6vREa41XfZ22I47cfti10Ik9dkU93Ouc57DPG49f1c/edit?usp=sharing

Reproducible:

Yes

Melekus commented 6 years ago

Game Version:

8.0.1 Beta Build 27602

Last Surprise isn't affected by Mastery: Dreadblade twice anymore, but it is still affected twice by the hidden specialization aura. It therefore deals 12% less damage than it should be.

edit: the spreadsheet in the first comment was updated with post-hotfix numbers

Melekus commented 6 years ago

Stealth-hotfixed during the 29th-30th september weekend (current build 27843)

Melekus commented 6 years ago

Actually not-so-stealthy hotfix: https://worldofwarcraft.com/en-gb/news/21973195/hotfixes-october-1-2018