SimCMinMax / WoW-BugTracker

Unofficial/Community Issue Tracker for current versions of World of Warcraft.
27 stars 6 forks source link

Dancing Rune Weapon's abilites damage double dips on Blood DK's spec aura #451

Open Chewsdaydk opened 4 years ago

Chewsdaydk commented 4 years ago

Game Version:

9.0.1 beta Build 34324

Description:

Dancing Rune Weapon's melee damage isn't affected by Blood's +29% spec aura, probably because there isn't a pet flag on the spec aura. The spells that DRW replicates are affected as they are replicated from your own spells

Howto:

Check damage in game vs checking manually what you'd expect, remove spec aura and it will match. Armour reduction i used here (0.675 mod) was cross referenced between dummies, hopefully it's accurate. All relevant info is in screenshots

Dancing Rune Weapon

image

White damage DRW inherits 1/3 AP (172+156) 1.08 1/3 = 94.32 and has a 3.5 second swing speed Avg. Weapon Damage + (Attack Power / 6) Weapon Speed spec aura armour reduc 0 + (94.32/6) 3.5 0.675 = 36

Melekus commented 4 years ago

A new effect was added on build 35598 to the blood death knight passive aura, increasing pet damage done by the same amount as direct/periodic damage.

See: simulationcraft/simc@99322bd#diff-76b32cba3fcac52ba73a75698348ba02R3611

Melee damage calculations take this modifier into account. Fixed.

New issue: DRW abilities' damage double dips with this new passive aura, as the system that applied the blood death knight direct damage aura on them is still in place.