Named random generation modifiers not working properly

SimGus / Chatette

A powerful dataset generator for Rasa NLU, inspired by Chatito

MIT License

319 stars 56 forks source link

Named random generation modifiers not working properly #19

Closed DevinTDHa closed 5 years ago

DevinTDHa commented 5 years ago

Hello,

I am encountering an issue with Chatette v1.5.0 PyPI (installed via pip).

Rule: I don't like [world?WWII] war[ II?WWII].

Expected examples:

I don't like war.
I don't like world war II.

Generated examples:

I don't like war.
I don't like war II.
I don't like world war.
I don't like world war II.

I tested it with a .chatette file and the interactive console. Both methods generate the same sentences.

SimGus commented 5 years ago

There is indeed a bug. I'll try to fix that as soon as possible.

Thanks for the heads up :)

SimGus commented 5 years ago

I can see why this problem is occurring. However, this would need quite a lot of changes on the problematic code, and since I am in the middle of a refactor of this code, I will not fix it right now. This will be fixed as soon as the refactor is over (which I hope doesn't take too long).

DevinTDHa commented 5 years ago

That's ok, good luck on the refactor!

SimGus commented 5 years ago

This is (finally) fixed in the latest version (v1.6.0) :)