SimHanKiong / pe

0 stars 0 forks source link

Add exam that happened earlier in the same day #13

Open SimHanKiong opened 2 months ago

SimHanKiong commented 2 months ago

Screenshot 2024-04-19 at 4.59.54 PM.png

I am unable to add an exam the day before but able to add an exam a few hours before which is quite inconsistent.

nus-pe-script commented 2 months ago

Team's Response

Same issue

It's stated in the UG that exams that is before the current time but on the same day can be inputted.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Past exam datetime is allowed

User Input: addexam -id 000001 -exam Computing -date 2024-04-19 -time 00:00 addexam -id 000001 -exam Computing -date 2024-04-19 -time 00:01

While a past date, before 19-April-2024 as of the PE, is properly blocked, a timing that has past is not. My user input should suggest the exam time is 19-April-2024, midnight and 12.01am respectively. The user input was keyed in on 19-April-2024 4.48pm

Expected: Error to show that the exam has already past. Actual: Exam is accepted.

image.png


[original: nus-cs2103-AY2324S2/pe-interim#2225] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

It's stated in the UG that exams that is before the current time but on the same day can be inputted. image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.Rejected`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]