SimNee / pe

0 stars 0 forks source link

Phone number validation #2

Open SimNee opened 4 years ago

SimNee commented 4 years ago

The application does not account for invalid phone numbers as the phone number is only validation is only for numbers ranging from 3 to 20 digits. But in actual fact, not all valid phone numbers lies in this range.

Screenshot 2019-11-15 at 4.22.04 PM.png

nus-pe-bot commented 4 years ago

Team's Response

"But in actual fact, not all valid phone numbers lies in this range."

From what we understand, you seem to suggest that there exists valid phone numbers that are less than 3 digits long or more than 20 digits long. However, based on the ITU-T's E.164 international phone number standard (the current standard in use), phone numbers (including country code) are limited to 15 digits.

Additionally (correct us if we're wrong), we are sure there isn't a single place in the world which has valid phone numbers < 3 digits long. And if such places exists, it should only affect up to 100 valid SIM cards out of billions in the world.

Hence, we believe that this constraint is sufficient for all possible practical use cases. In fact, the responsibility of entering a valid phone number falls on the user - this is the equivalent of claiming "the Contacts app on my phone has a bug because it allows me to enter the phone number 12345678901234567890".

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]