search

SimVascular / simvascular.github.io-archive

SimVascular website
4 stars 11 forks source link

Restructure the SimCardio page #115

Open CZHU20 opened 2 years ago

CZHU20 commented 2 years ago

Now that svFSI has its own dedicated pages, the existing SimCardio page can be restructured to better demonstrate the scope of the project. I would like to propose a change like this: image

Here, Cardiac Geometric Modeling Tools describes Fanwei's machine-learning based cardiac modeling workflow. Multiphysics finite element solver will direct readers to svFSI page. Purkinje Network Plugin showcases the generation of Purkinje network using SimVascular plugin.

ktbolt commented 2 years ago

@CZHU20 I think it is better to use Cardiac Modeling rather than SimCardio to refer to the cardiac modeling functionality. SimCardio implies that this is a software package or a tool that is part of SV.

At some point I will replace the Clinical Studies page with an Applications page and move the SimCardio docs there.

CZHU20 commented 2 years ago

@ktbolt Thanks for the feedback. I can change that to Cardiac Modeling. I am still a bit confused about the role of SimCardio. Do we need to mention SimCardio at all on this page?

I think we used to refer to it as "the SimVascular SimCardio software suite" to treat it more like a plugin in SimVascular.

ktbolt commented 2 years ago

@CZHU20 I don't think we need to mention SimCardio. SimCardio used to be a repository that contained the Purkinje plugin but that was renamed to SimVascular-Plugin-Purkinje-Network, SimCardio is no longer used and should be removed.

CZHU20 commented 2 years ago

I see. Will make the changes, but will keep them in my own branch for now. I have just submitted a revision to the JOSS paper, in which the reviewer asked about the relation between SimCardio and svFSI. I think it's best we postpone the changes to the SimCardio page so as not to confuse the reviewer.

CZHU20 commented 1 year ago

@ktbolt

Hi Dave,

Sid’s documentation requires readers to have access to some examples currently hosted on the private repo, mostly contents in these two folders: https://github.com/StanfordCBCL/Cardiac_Modeling_Tools/tree/master/cardiac-multiphysics-pipeline/01-fibers/biventricular https://github.com/StanfordCBCL/Cardiac_Modeling_Tools/tree/master/cardiac-multiphysics-pipeline/01-fibers/idealized_lv

Can we host them somewhere with public access?