search

SimVascular / svFSI

A multi-physics finite element solver for patient-specific blood flow simulation including fluid-structure interaction and cardiac electrophysiology
Other
31 stars 49 forks source link

Code updates for cardiac mechanics benchmark #114

Closed vvedula22 closed 1 year ago

vvedula22 commented 1 year ago

See issue #113

ktbolt commented 1 year ago

@vvedula22 These changes are too extensive for a single pull request, hundreds of lines of code changed in 30 files! And all changes from a single master branch.

You will need to open Issues for each code section describing what functions have been changed and why, implement those changes in a separate branch and create a pull request for it.

The larger issue is that new development should be in the svFSI C++ version. If you add new code to the Fortran svFSI version then you will also need to make the same changes to the C++ version.

vvedula22 commented 1 year ago

@ktbolt I understand. I had created these code changes in a separate branch "cardiac_benchmark", but eventually merged them into the master branch once I was confident that all the issues were fixed and tested. I created this pull request so @aabrown100-git can run his coupled simulations for his paper.

I am not good with C++ and it will take a long time for me to write code using it. Because I had to try these ideas in a short span of time, I went ahead with the Fortran version.

ktbolt commented 1 year ago

@vvedula22 There is not much C++ knowledge needed to modify the C++ code, it is basically line-by-line the Fortran code, same variable names and organization, just subtract 1 from the array indices!