SimVascular / svFSIplus

This repository contains a line-by-line conversion of the Fortran svFSI solver to C++.
Other
6 stars 19 forks source link

Add a CMake flag to set array index checking #163

Closed ktbolt closed 5 months ago

ktbolt commented 5 months ago

I've added CMake commands to set the ENABLE_ARRAY_INDEX_CHECKING C++ directive used by the Array templates to check Array indices (https://github.com/SimVascular/svFSIplus/issues/146).

The CMake ENABLE_ARRAY_INDEX_CHECKING variable should be enabled when testing.

mrp089 commented 5 months ago

For future reference, this PR (with array checking enabled) almost doubles the execution times for our tests (before/after):

I think it's fine to merge, but @ktbolt, @MatteoSalvador, please let me know if not.

We can keep this in mind if we want to split up testing in the future (e.g., every commit, every PR, nightly, weekly).