Bug fix in Holzapfel tangent component

aabrown100-git commented 3 months ago

Current situation

Holzapfel material test case has very slow convergence (https://github.com/SimVascular/svFSIplus/issues/189). This was introduced during material model restructuring (https://github.com/SimVascular/svFSIplus/pull/159).

Release Notes

Miniscule bug fix in one component of the tangent matrix for the Holzapfel material model

Testing

test_LV_Holzapfel_passive now displays excellent convergence

---------------------------------------------------------------------
 Eq     N-i     T       dB  Ri/R1   Ri/R0    R/Ri     lsIt   dB  %t
---------------------------------------------------------------------
 ST 1-1  3.900e-02  [0 1.000e+00 1.000e+00 8.962e-07]  [84 -45 13]
 ST 1-2  8.100e-02  [-25 5.159e-02 5.159e-02 9.870e-07]  [92 -55 14]
 ST 1-3  1.240e-01  [-74 1.835e-04 1.835e-04 9.218e-07]  [89 -51 12]
 ST 1-4s 2.200e-01  [-194 1.800e-10 1.800e-10 1.448e-03]  [47 -65 13]

Code of Conduct & Contributing Guidelines

[x] I agree to follow the Code of Conduct and Contributing Guidelines.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0590d9a) 57.50% compared to head (c6e7301) 57.50%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #190 +/- ## ======================================= Coverage 57.50% 57.50% ======================================= Files 103 103 Lines 26964 26964 ======================================= Hits 15505 15505 Misses 11459 11459 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aabrown100-git commented 3 months ago

Is there a way to check the LV_Holzapfel_passive output on Github machines to verify proper convergence behavior?

mrp089 commented 3 months ago

Good idea! You can change the pytest argument https://github.com/SimVascular/svFSIplus/blob/0590d9ad99a67940d1c0dc980b9fe967523487de/.github/workflows/test.yml#L41 to pytest -rPv --durations=0

aabrown100-git commented 3 months ago

I have confirmed proper convergence behavior on Github machines. Ready to merge.

aabrown100-git commented 3 months ago

@MatteoSalvador

mrp089 commented 3 months ago

Thanks!

SimVascular / svFSIplus