SimVascular / svFSIplus

svFSIplus is an open-source, parallel, finite element multi-physics solver.
https://simvascular.github.io/documentation/svfsi.html
Other
8 stars 23 forks source link

The Name_prefix_of_saved_VTK_files parameter does not have a default value #224

Open ktbolt opened 2 months ago

ktbolt commented 2 months ago

Description

The Name_prefix_of_saved_VTK_files parameter should have a default value of result. Instead it has no default value so if it is not given in the solver XML file the VTK output files look like _001.vtu.

Reproduction

Remove the Name_prefix_of_saved_VTK_files parameter from any solver XML file and run a simulation.

Expected behavior

Not giving the Name_prefix_of_saved_VTK_files parameter in a solver XML file should create VTK output files that look like result_001.vtu.

Additional context

No response

Code of Conduct

ktbolt commented 2 months ago

In the GeneralSimulationParameters::GeneralSimulationParameters() method need to change

  set_parameter("Name_prefix_of_saved_VTK_files", "", !required, name_prefix_of_saved_vtk_files);

to

  set_parameter("Name_prefix_of_saved_VTK_files", "result", !required, name_prefix_of_saved_vtk_files);