Using a VTU file for the Traction_values_file_path causes a failure

SimVascular / svFSIplus

svFSIplus is an open-source, parallel, finite element multi-physics solver.

https://simvascular.github.io/documentation/svfsi.html

Other

8 stars 23 forks source link

Using a VTU file for the Traction_values_file_path causes a failure #235

Closed ktbolt closed 2 weeks ago

ktbolt commented 1 month ago

Description

The solver input XML Traction_values_file_path takes a VTP file as a value.

However, if a VTU file is given it is not detected as an error and svFSIplus crashes.

Reproduction

See above.

Expected behavior

See above.

Additional context

No response

Code of Conduct

[X] I agree to follow this project's Code of Conduct and Contributing Guidelines

ktbolt commented 2 weeks ago

I've added a VtkData::check_file_extension() function to check for a given file extension and added this check to several functions in read_files, read_msh and load_mesh.

ktbolt commented 2 weeks ago

I got this wrong!

It seems that some of the boundary condition data files can either be VTP or VTU files even though the Fortran code and documentation suggest otherwise

function name is read_vtu_pdata()
in the code there is TYPE(vtkXMLType) :: vtu
svFSI_master.inp states applied by reading a vtp file

I've modifie the read_trac_bcff() function to read either a vtp or vtu file like all of the other functions that read in boundary condition data.

ktbolt commented 2 weeks ago

Merged into main.