SimVascular / svFSIplus

svFSIplus is an open-source, parallel, finite element multi-physics solver.
https://simvascular.github.io/documentation/svfsi.html
Other
8 stars 23 forks source link

Add new material models and excitation-contraction coupling from svFSI #76

Closed ktbolt closed 10 months ago

ktbolt commented 1 year ago

The Fortran svFSI code has several changes to material models that we need to add to svFSIplus

I think HGO-modified and HO-modified are new.

HGO-decoupled and HO-decoupled seem to be HGO and HO renamed. I will still need to figure out if these have been modified.

ktbolt commented 1 year ago

I'm going to also add the new excitation-contraction coupling implementation here since the material models need this.

ktbolt commented 1 year ago

I've converted the updated material models, updated a bunch of functions and added new material types (enums)

I see a lot of code duplication in the material models code. I will need to think about how to better organize material models in the Stage 2 code.

ktbolt commented 1 year ago

I've updated and converted more code for excitation-contraction coupling

ktbolt commented 1 year ago

I've updated and converted more code for excitation-contraction coupling

There appears to be a new file type that stores parameters for excitation-contraction coupling. This is used to overwrite default excitation-contraction coupling parameters. The parameters seem to be stored like

<NAME>: <VALUE>

Is this correct @vvedula22

There is also a new parameter section called Excitation-contraction coupling defined for the solver input file. @vvedula22 The excitation-contraction coupling parameters are not documented in the svFSI_master.inp file, please update it.

vvedula22 commented 1 year ago

@ktbolt Yes, that is correct. Will update svFSI_master.inp on the usage soon and also couple of test cases to the examples repository.

ktbolt commented 1 year ago

@vvedula22 Thanks!

ktbolt commented 1 year ago

I've added more excitation-contraction code

modified:   CepMod.h
modified:   ComMod.h
modified:   Simulation.h
modified:   cep.cpp
modified:   cep_ion.cpp
modified:   distribute.cpp
modified:   fsi.cpp
modified:   initialize.cpp
modified:   mat_models.cpp
modified:   mesh.cpp
modified:   output.cpp
modified:   pic.cpp
modified:   read_files.cpp
modified:   read_files.h
modified:   set_equation_props.h
added: EcMod.cpp
added: EcMod.h
added: ec_dcpld.cpp
added: ec_dcpld.h

Adding new Fortran code from svFSI is truly a nightmare trying to figure out what to add/modify in the C++ code.

ktbolt commented 1 year ago

@vvedula22 I am now stalled on the conversion. I need 1) updated svFSI_master.inp with the new excitation-contraction parameters 2) Format of the excitation-contraction parameter files 3) svFSI-Tests examples

vvedula22 commented 1 year ago

@ktbolt Will do. Just wanted to make sure the mechanics model is properly validated before uploading it to svFSI-Tests.

aabrown100-git commented 12 months ago

@vvedula22 @ktbolt What's the status of this issue? I'd like to test @vvedula22 's cardiac benchmark simulation in svFSIplus, but it seems the excitation-contraction coupling is not fully implemented yet.

ktbolt commented 12 months ago

@aabrown100-git I've added the new material models but there are no tests to check the C++ implementation so I have not checked-in the changes.

ktbolt commented 10 months ago

Recent changes to the svFSI material models makes the changes I made obsolete, better to just start over.