I found out the linear material model is broken when I was testing the backwards compatibility of the leaky vessels code with previous sv input files. I initially thought it was my code that was broken, but the code just didn't handle linear materials properly.
Release Notes
Changed the following functions in cvOneDMaterialLinear.cxx: GetArea(), GetPressure(), GetDpDS(). Not sure how the previous maintainer arrived at these forms, but they differ a lot from the implementation in cvOneDMaterialOlufsen.cxx, which doesn't make much sense (since the two models are only different in the EHR computation).
Changed the function GetN() in cvOneDMaterialLinear.h from "return 0.0;" to "return N;".
Added relevant test cases so that the linear material can be tested when future versions of the code are changed.
Documentation
Just a bug fix.
Testing
Please ensure that the PR meets the testing requirements set by GitHub Actions.
See above for testing results. The linear material should undergo tests now.
Current situation
110
I found out the linear material model is broken when I was testing the backwards compatibility of the leaky vessels code with previous sv input files. I initially thought it was my code that was broken, but the code just didn't handle linear materials properly.
Release Notes
Documentation
Testing
Please ensure that the PR meets the testing requirements set by GitHub Actions.
Code of Conduct & Contributing Guidelines