search

SimVascular / svSolver

Separate repository for svSolver
16 stars 23 forks source link

Build Docker and Singularity containers #70

Open ktbolt opened 4 years ago

ktbolt commented 4 years ago

Although no user has requested this, it would be interesting and useful to build containers for Docker and Singularity for svSolver executables. Singularity is supported on many HPC clusters including Sherlock, Comet and Xsede.

Some users have had difficulties building svSolver from source, usually because of the VTK dependencies but also sometimes CMake has problems finding MPI. A container would allow users to use svSolver without having to build from source and would simplify our delivery process, we would only need to build for a single OS.

ktbolt commented 4 years ago

@vsoch I'll build a Docker container for svSolver as a first shot at this, show you what the dependancies are. I've built Docker containers for several HPC applications in the past.

@ellipsis14 Please try to build svSolver from source to get you started.

vsoch commented 4 years ago

@ktbolt could you PR to my repository (or would you like me to transfer it here?) It already has a lot of good starting work and documentation, and I'm totally okay with you changing it however you see fit!

vsoch commented 4 years ago

I could transfer to SimVascular and then you could call it "docker-containers" or something like that, and then I can help you set up an automated build strategy.

ktbolt commented 4 years ago

@vsoch I will definitely use your starting work. I'll just pick it off of your repository. Thanks!

I'm not sure what the plan is going to be to provide containers, need to discuss with Alison and Nathan.

vsoch commented 4 years ago

Ok, but please be respectful of copy pasting without giving any credit to the contribution that I made. This is what git history is good for, so even if I transferred the repository here and you changed much of it, the work that I did would be in the record! Doing any kind of copy paste without proper accreditation is like slapping someone in the face or stealing in the open source world. We are on the same team and I’ve tried to figure out how to best communicate and work with you and I feel you shutting me out every single time. Please, if you can, try to work with me too :)

vsoch commented 4 years ago

For record on this issue, I’ve put quite a bit of work into this already: https://github.com/vsoch/simvascular and in a closed PR a user has wanted to try a container.

ktbolt commented 4 years ago

@vsoch What I meant by pick it off of your repository was to use what you did to test building a container. When we decide to incorporate building containers into the svSolver repository I will be sure to incorporate your repository and its history.

vsoch commented 4 years ago

Awesome!! I'm really glad that we can work together :) I will stay tuned for your instruction!