Change in results with json input files - Githubissues

SimVascular / svZeroDSolver-Archived

A Python lumped-parameter solver for blood flow and pressure in hemodynamic networks

Other

12 stars 15 forks source link

Change in results with json input files #44

Closed mrp089 closed 3 years ago

mrp089 commented 3 years ago

I reran my 3D-0D comparison with the current versions of SimVascular and svZeroDSolver that both support the new json input file format. The results compared to the previous text input file are quite different and I don't understand why. See below the results of the last 0D cardiac cycle vs. 3D. Both pressure level and flow splits seem quite off.

Things I have considered so far:

as far as I can tell, the information in both input files is identical
initialization from zero yields the same results
same problems with resistance BCs

Results text input SimVascular https://github.com/SimVascular/SimVascular/commit/19e6fb6f26600da0cbc99def4a93dcf377ddc7ac svZeroDSolver a3299609d2f70009f18078139cc1743901e0d0b5

0075_1001_0d_text.txt

0075_1001_caps

Results json input SimVascular https://github.com/SimVascular/SimVascular/commit/031bdd245f19715c1ce270f1763687c3b604c70a (plus: output of C and L commented) svZeroDSolver 2e2acffc1ec61f3a7f05035f3642c36142094cc1

0075_1001_0d_json.txt

0075_1001_caps

@JonathanPham, can you take a look at what went wrong here?