SimVascular / svZeroDSolver

A C++ lumped-parameter solver for blood flow and pressure in hemodynamic networks
Other
6 stars 18 forks source link

Output .csv file truncates time steps for a large (>93) vessel system #105

Closed chlookaburra closed 3 months ago

chlookaburra commented 6 months ago

Description

I am running a 116-vessel system with 1000 time steps and 10 cardiac cycles, and outputting the final cardiac cycle ("output_all_cycles": false).

The issue is that, starting with the 93th vessel, only 984 time steps are printed in the .csv file. Before that, 1000 time steps are printed.

results_bug_length.csv

Reproduction

test0d_no_calib_refined.json

Create any >93 vessel system and set the following simulation parameters:

"simulation_parameters": { "number_of_cardiac_cycles": 10, "number_of_time_pts_per_cardiac_cycle": 1000, "output_all_cycles": false },

Expected behavior

I was expecting to see a .csv file with 1000 time steps per vessel.

Additional context

No response

Code of Conduct

menon-karthik commented 4 months ago

@natalia-rubio Any chance this is related to #100?

kharold23 commented 3 months ago

I ran the simulation with the attached json, and the output isn't truncated for me.
results.csv

I'm using MacOS and the newest version of sv0D... What operating system did you run it on? (There have been system-specific issues before)

chlookaburra commented 3 months ago

I ran it on a MacOS when this issue was posted. I just checked again—and it works with the newest version of svZeroDSolver.