Open alexkaiser opened 4 days ago
Some LPN blocks such as the chamber block have time-dependent parameters, but explicit time-dependence is not implemented in the calibrate program.
This will allow blocks with time-dependent to be used by the calibrate program.
Time and time-dependent variables for each block should be updated in the calibrate program in the main loop over the time series.
The code could potentially be modified from the main solver loops over time.
An initial attempt at adding chamber blocks to configure (that does not yet work) was thwarted by the lack of time-dependent updates. See this fork for (incomplete) code: https://github.com/alexkaiser/svZeroDSolver/tree/chamber_calibrate
Use Case
Some LPN blocks such as the chamber block have time-dependent parameters, but explicit time-dependence is not implemented in the calibrate program.
Problem
This will allow blocks with time-dependent to be used by the calibrate program.
Solution
Time and time-dependent variables for each block should be updated in the calibrate program in the main loop over the time series.
Alternatives considered
The code could potentially be modified from the main solver loops over time.
Additional context
An initial attempt at adding chamber blocks to configure (that does not yet work) was thwarted by the lack of time-dependent updates. See this fork for (incomplete) code: https://github.com/alexkaiser/svZeroDSolver/tree/chamber_calibrate
Code of Conduct