Clean up code

[ktbolt]

I will clean up the code a bit to follow best practices and such.

[menon-karthik]

@ktbolt Can you elaborate a little bit on the best practices you have in mind? Might be useful to have this documented somewhere for posterity.

[ktbolt]

@menon-karthik Some of these are stated in Coding Guidlines but most are C++ practices that everybody knows.

I should create a Lab document for this with links to appropriate websites and such.

[ktbolt]

Note that developers will look at the current code to see how things are done.

[mrp089]

@ktbolt, it would be great to add your C++ standards to https://github.com/SimVascular/.github on the off chance that not everybody has the same ideas as you. The one you linked is very svFSI/FORTRAN specific.

Can you briefly say what you plan for 0D+ specifically?

[ktbolt]

@mrp089 These are not really my standards.

C++ best practices have been developed over the years by the C++ community, Bjarne Stroustrup, Herb Sutter, Scott Meyers and others.

I will try to produce a document that distills the essence of the C++ best practices.

[mrp089]

Cool!

Specifically for 0D+, what are your plans?

[ktbolt]

I have no grand plan for the ZeroDSolver. I will just go through the code and add/modify it as needed.

However, a couple of things I have noticed when removing templates and testing

• Add error checking to applications main (svzerodsolver segfaults when given no arguments, input files are not checked if they exist, catch nlohmann::json parse errors, etc.)
• Add error checking to calibrate
• Lots of empty constructors/destructors (maybe because of Eigen)
• Remove any magic numbers and literals (e.g. "F")
• Clean up any template residue

[ktbolt]

I've made several changes

• Added error checking to svzerodcalibrator and svzerodsolver main functions.
• Made enum class BlockType names more readable closed_loop_coronary_lefT_bc replaces CLOSEDLOOPCORONARYLEFTBC
• Replaced unsigned int with int
• Replaced std::map<std::string, int> num_triplets map with TripletsContributions struct num_triplets.F replaces num_triplets["F"]

[ktbolt]

I've made some more changes

• removed some empty constructions
• defined const functions where appropriate
• removed this-> from vessel blocks

This all I'm going to do for this Issue.

There are other specific parts of the implementation that I would like to improve like removing the heavy use for string literals in the code to identify parameters, types and such. I'll open separate Issues for those improvements.

[ktbolt]

Merge into main.