search

SimVascular / svZeroDSolver

A C++ lumped-parameter solver for blood flow and pressure in hemodynamic networks
Other
6 stars 18 forks source link

Allow user-provided dependencies #60

Open burgreen opened 10 months ago

burgreen commented 10 months ago

Thanks you for sharing this software!

Do any of your test cases replicate the P-V curve of a cardiac cycle?

I would suggest modifying your CMakeLists.txt to not require forced downloads of Eigen and the other 3 dependencies. If users have those packages already installed on their machines, let them supply the CMAKE_PREFIX_PATH and your CMakeLists.txt perform a find_package( xxx, REQUIRED) to locate the info.

burgreen commented 10 months ago

Found what I was seeking in your ClosedLoopHeartPulmonary class along with the paper reference!

mrp089 commented 10 months ago

Thank you, @burgreen! It's a good idea to have a flag for user-provided dependencies.