search

SimVascular / svZeroDSolver

A C++ lumped-parameter solver for blood flow and pressure in hemodynamic networks
Other
6 stars 18 forks source link

Fixed doxygen warnings and make the build fail for undocumented code #72

Closed menon-karthik closed 10 months ago

menon-karthik commented 10 months ago

Closes #46

I fixed the previous warnings by adding the necessary documentation. The github actions should now fail and prevent undocumented code from being merged.

menon-karthik commented 10 months ago

The documentation is failing to build because the github actions can't find a package that it could find a few hours ago! I checked that it isn't from my changes by pushing a "test" commit in this branch where the only change fromStanfordCBCL:master is that I removed one random word in the documentation in Block.h. So although that branch is essentially the same as StanfordCBCL:master, the documentation fails to build with the same error. @mrp089 @ktbolt have you seen this before?

ktbolt commented 10 months ago

@menon-karthik I've not seen this before, just tried to rerun it and it failed.

menon-karthik commented 10 months ago

@mrp089 did some digging and it turns out the package that is failing was updated today. Fingers crossed that this resolves itself.

mrp089 commented 10 months ago

@menon-karthik, if you push to this branch now, does the documentation build?

menon-karthik commented 10 months ago

@menon-karthik, if you push to this branch now, does the documentation build?

Nope.

mrp089 commented 10 months ago

Try downgrading mattnotmitt/doxygen-action: https://github.com/mattnotmitt/doxygen-action

Maybe this only affects the edge version.

mrp089 commented 10 months ago

@menon-karthik, happy to merge this first and then I'll deal with the conflicts in #74