SimVascular / svZeroDSolver

A C++ lumped-parameter solver for blood flow and pressure in hemodynamic networks
Other
6 stars 18 forks source link

Simplify block generation #78

Closed mrp089 closed 9 months ago

mrp089 commented 10 months ago

Current situation

Closes #70 and #71: Simplifies block generation and introduces more error checking.

Release Notes

Major structure:

Major in solve/SimulationParameters.cpp (the file formerly known as io/configreader.hpp):

New error checks:

Minor:

Limitations:

Documentation

I updated the Doxygen documentation. After merging this, we can create a section on creating new blocks in the developer guide (#66).

Testing

We have built ourselves a very nice CI framework! I worked myself through all the block and interface tests. I made the following changes to the input files:

Code of Conduct & Contributing Guidelines

mrp089 commented 10 months ago

I added more input checks after talking to @richterjakob and edited the first comment accordingly.