We could unify this by requiring every block to have name, type, values, simplifying reading the input file. An exception is ClosedLoopHeartAndPulmonary, which doesn't have a name or type (but could have in the future?).
The changes to the SimVascular 0D model generation would be very simple and limited to this file. However, it would also mean that all current users need to change their input files. We could provide a Python script for the migration.
@menon-karthik, any thoughts on if this is worth doing (and if yes, how to do it)? Any other changes we should make in addition?
While working on #83, I noticed that we have different names for the same attributes in different 0D blocks:
vessel_name, bc_name, junction_name, name
, no namezero_d_element_type, bc_type, junction_type, closed_loop_type, type
, no typezero_d_element_values, bc_values, junction_values, values
We could unify this by requiring every block to have
name, type, values
, simplifying reading the input file. An exception isClosedLoopHeartAndPulmonary
, which doesn't have aname
ortype
(but could have in the future?).The changes to the SimVascular 0D model generation would be very simple and limited to this file. However, it would also mean that all current users need to change their input files. We could provide a Python script for the migration.
@menon-karthik, any thoughts on if this is worth doing (and if yes, how to do it)? Any other changes we should make in addition?