SimVascular / svZeroDSolver

A C++ lumped-parameter solver for blood flow and pressure in hemodynamic networks
Other
6 stars 18 forks source link

Unify attribute names? #85

Open mrp089 opened 9 months ago

mrp089 commented 9 months ago

While working on #83, I noticed that we have different names for the same attributes in different 0D blocks:

We could unify this by requiring every block to have name, type, values, simplifying reading the input file. An exception is ClosedLoopHeartAndPulmonary, which doesn't have a name or type (but could have in the future?).

The changes to the SimVascular 0D model generation would be very simple and limited to this file. However, it would also mean that all current users need to change their input files. We could provide a Python script for the migration.

@menon-karthik, any thoughts on if this is worth doing (and if yes, how to do it)? Any other changes we should make in addition?

menon-karthik commented 9 months ago

I'm on board with this! I think we should retain the backward compatibility as long as it isn't difficult to maintain.