SimVascular / svZeroDSolver

A C++ lumped-parameter solver for blood flow and pressure in hemodynamic networks
https://simvascular.github.io/documentation/rom_simulation.html#0d-solver
Other
7 stars 18 forks source link

Rename svZeroDPlus to svZeroDSolver #91

Closed menon-karthik closed 10 months ago

menon-karthik commented 10 months ago

Current situation

Addresses #86 and #35. The move from StanfordCBCL to SimVascular involved renaming the repo to svZeroDSolver for consistency. The name therefore had to be updated in several places within the repo.

Release Notes

Documentation

This PR mostly updates the docs. No code changes.

Testing

Github actions are passing.

Code of Conduct & Contributing Guidelines

menon-karthik commented 10 months ago

@richterjakob I requested your review because I might have broken some things in the python interface and docker container while renaming things. I'm not sure if I did, because the tests are passing but I'm assuming the testing doesn't include the docker container. Please don't feel like you need to spend too much time on this, but just wanted to make sure those two things are working!

menon-karthik commented 10 months ago

@mrp089 Thanks for approving! I'll wait for @richterjakob to look at it whenever he gets a chance before merging (no hurry).

mrp089 commented 10 months ago

Merging, as @richterjakob and I want to use the new name in https://github.com/StanfordCBCL/svSuperEstimator. He accepts the name changes with a tear in his eye.