SimVascular / vascularmodel

Other
1 stars 2 forks source link

Microscape embed #3

Closed JPFrancis closed 11 months ago

JPFrancis commented 12 months ago

Microscape embed pull request

Current situation

Microscape iframe has been embedded as a popup window in the dataset.html page

Release Notes

Up to date with master and should not be a breaking change although it has yet to be tested with VMR server hookups.

Documentation

See main.js "threeDOverlay" functions

Testing

Open the database and click on the microscape button for any project

ktbolt commented 12 months ago

@JPFrancis I don't see an Issue justifying this added functionality. What is this all about?

lucapegolotti commented 12 months ago

@ktbolt, you're right, sorry. We've been working for a few months with Microscape and Kitware to develop a custom 3D viewer to embed in the VMR website when browsing through the models. Alison is aware of this-in fact, we've set up a contract to be able to collaborate with Microscape and Kitware. This PR embeds the 3D viewer into the VMR website. I will deploy the website with github pages before merging it to tetra so we can show how it works to Alison, and then once we get the green light move it to the vascularmodel.com. I will create a separate issue and link it to this PR.

ktbolt commented 12 months ago

@lucapegolotti Very good!

lucapegolotti commented 11 months ago

A preview of the new version of the website can be seen here: https://jpfrancis.github.io/vascularmodel/dataset.html

@ktbolt, what do you think about it? You can click on any of the models that have a Microscape logo below the checkbox to open the 3D viewer.

ktbolt commented 11 months ago

@lucapegolotti The visualization looks OK, nice to provide an anatomical context for the model I suppose, although the model context is not that apparent.

I think the icon that opens the visualization should be moved to the upper right. The icon should also be changed to something more descriptive rather than what looks to me like a picture of the endoplasmic reticulum.

The visualization window could have a better description than just Here is the 3D visualization., maybe something like Volume rendering of image 0086_H_PUM_PAH.

Is it possible to include some control over the rendering like data mapping ?

alisonmarsden commented 11 months ago

This looks good to me. I see you’ve made the changes that Dave suggested. I’m in favor of merging in. This worked out nicely!

From: Dave Parker @.> Date: Monday, November 27, 2023 at 10:42 AM To: SimVascular/vascularmodel @.> Cc: Subscribed @.***> Subject: Re: [SimVascular/vascularmodel] Microscape embed (PR #3)

@lucapegolottihttps://github.com/lucapegolotti The visualization looks OK, nice to provide an anatomical context for the model I suppose, although the model context is not that apparent.

I think the icon that opens the visualization should be moved to the upper right. The icon should also be changed to something more descriptive rather than what looks to me like a picture of the endoplasmic reticulum.

The visualization window could have a better description than just Here is the 3D visualization., maybe something like Volume rendering of image 0086_H_PUM_PAH.

Is it possible to include some control over the rendering like data mapping ?

— Reply to this email directly, view it on GitHubhttps://github.com/SimVascular/vascularmodel/pull/3#issuecomment-1828412982, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADJGJZ7VWMMCVSHBVFRQ563YGTNIXAVCNFSM6AAAAAA7J4H4F2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRYGQYTEOJYGI. You are receiving this because you are subscribed to this thread.Message ID: @.***>

ktbolt commented 11 months ago

@lucapegolotti Looks much better! Mousing over the icon displays view details for, maybe change this to volume rendering of or something.