IanTapply22 commented 10 months ago

Description

Fixed all linting and build violations with spotless apply.

This PR depends on #20 to be completed and merged before this can be merged. We also need to update the 2024-beta branch to merge this as there are some conflicts with these changes.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation, if any
[x] My changes generate no new warnings
[x] I have performed tests that prove my fix is effective or that my feature works, if necessary
[x] New and existing unit tests pass locally with my changes

IanTapply22 commented 10 months ago

Again, to clarify then this doesn't get messed up. THIS PR DEPENDS ON #20 TO BE MERGED BEFORE MERGING THIS

colemacphail commented 10 months ago

Again, to clarify then this doesn't get messed up. THIS PR DEPENDS ON #20 TO BE MERGED BEFORE MERGING THIS

@IanTapply22 one cool trick we use at work is that you can set up a github workflow to make it so you can't merge if the PR description has something like "DO_NOT_MERGE" in it. Something to think about if we care lol

IanTapply22 commented 10 months ago

Again, to clarify then this doesn't get messed up. THIS PR DEPENDS ON #20 TO BE MERGED BEFORE MERGING THIS

@IanTapply22 one cool trick we use at work is that you can set up a github workflow to make it so you can't merge if the PR description has something like "DO_NOT_MERGE" in it. Something to think about if we care lol

We should totally do that, I'll make an issue for that when I can!

IanTapply22 commented 10 months ago

Again, to clarify then this doesn't get messed up. THIS PR DEPENDS ON #20 TO BE MERGED BEFORE MERGING THIS

@IanTapply22 one cool trick we use at work is that you can set up a github workflow to make it so you can't merge if the PR description has something like "DO_NOT_MERGE" in it. Something to think about if we care lol

25 :)

IanTapply22 commented 10 months ago

No

Simbotics / Simbot-Base

Fix linting and build violations #22

Description

Type of change

Checklist:

25 :)