search

Simek / yarn-lock-changes

Creates a comment inside Pull Request with the human-readable summary of changes to the Yarn lock file. Works with every Yarn version (classic and berry).
https://github.com/marketplace/actions/yarn-lock-changes
MIT License
132 stars 20 forks source link

Feature Request: more detailed/correct information when package become duplicated #42

Open Bnaya opened 3 years ago

Bnaya commented 3 years ago

Intro: yarn.lock file may contain several versions of the same dependency. When adding/upgrading packages using yarn, you sometimes end up not with an upgrade, but with an additional of another version of the package.

In the current state of this action, when another version is added, it still marks it as updated. I think it will be more correct to mark it as "added" with the new version, and not as update, or created additional kind of indication for that.

I will try to open a PR to emphasis that.

Worth noting: yarn-deduplicate is an important tool that dramatically helps avoiding unneeded duplications (Some duplications are needed) https://github.com/atlassian/yarn-deduplicates

Bnaya commented 3 years ago

Please approve the action to run on my PR https://github.com/Simek/yarn-lock-changes/pull/43 :)