SimenB / add-asset-html-webpack-plugin

Add a JavaScript or CSS asset to the HTML generated by html-webpack-plugin
MIT License
335 stars 42 forks source link

Assets refreshing not working with html-webpack-plugin v4 #175

Open weareoutman opened 4 years ago

weareoutman commented 4 years ago

Hi, thanks for the great work of this plugin.

It seems not working well with html-webpack-plugin v4. The compilation missing to refresh assets after assets updated.

I created a repo which can reproduce the bug. Hope it will help.

Reproducing steps:

  1. Run npm start
  2. Update assets/dll.js
  3. Watch the webpack log, it does re-compile, but no assets updated.
  4. Open the dist/dll.js, it's stale. (the devServer.writeToDisk option is just for convenience of debugging)

More info:

When webpack first started, the assets do be added:

Version: webpack 4.42.1
Time: 334ms
Built at: 04/10/2020 10:18:50 PM
          Asset       Size  Chunks             Chunk Names
         dll.js   19 bytes          [emitted]  
     index.html  263 bytes          [emitted]  
index_bundle.js    360 KiB    main  [emitted]  main
Entrypoint main = index_bundle.js

But when assets file updated, the re-compilation missed the assets.

ℹ 「wdm」: Compiling...
ℹ 「wdm」: Hash: a7a08df7cdac9b2219d8
Version: webpack 4.42.1
Time: 10ms
Built at: 04/10/2020 10:19:01 PM
 1 asset
Entrypoint main = index_bundle.js
   33 modules
ℹ 「wdm」: Compiled successfully.

And when I downgrade the html-webpack-plugin to v3, it works again.

xhavit commented 4 years ago

@weareoutman I'm having the same problem and looking forward to solving it.

weareoutman commented 4 years ago

For those who having the same problem, I have switched to html-webpack-tags-plugin which works.