search

SimenB / stylint

Improve your Stylus code with Stylint
https://simenb.github.io/stylint/
GNU General Public License v2.0
348 stars 61 forks source link

Add method for banning functions. #338

Closed dristic closed 8 years ago

dristic commented 8 years ago

This is a small request to add new functionality to the linter for banning specific key words. It allows you to specify a list of key words that will get flagged in the linter when found. The use case for this is banning the use of things like translate3d in your application:

"bannedFunctions": ["translateX", "translateY", "translate3d"]

Let me know what you think @rossPatton , this would be a huge help for what we are trying to do.

SimenB commented 8 years ago

This seems like an ok addition to me.

Sorry about the late response!

dristic commented 8 years ago

Thanks for the review! I will get this cleaned up and ready this/next week.

dristic commented 8 years ago

Okay I fixed those and re-pushed. Let me know if I should change anything else!

SimenB commented 8 years ago

Woops, should have been merged to develop...

SimenB commented 8 years ago

@dristic I reverted the merge again. Could you fix the comment and open a PR against develop instead of master? Sorry about that 😄

dristic commented 8 years ago

My bad! Will fix next week!

SimenB commented 8 years ago

@dristic ping 😄

SimenB commented 8 years ago

@dristic Another ping, I'd like this feature myself

dristic commented 8 years ago

Sorry! I totally forgot about this. Let me try to get to it tomorrow.