search

SimenB / stylint

Improve your Stylus code with Stylint
https://simenb.github.io/stylint/
GNU General Public License v2.0
348 stars 61 forks source link

Look into dropping stampit #359

Open SimenB opened 7 years ago

SimenB commented 7 years ago

Not sure if we want to put the effort into doing this, but personally I'm not a fan of magical this, and much prefer composing a bunch of pure functions together.

As we already will decouple rules and reporters from this (#356, #358), what really is left? It'd just be a place to chuck violations, or whatever we will call it.

Not having stampit would probably make the code more testable as well, as it stands, init calls read etc., makes init wonky to write tests for.

SimenB commented 7 years ago

The test suite takes a long time to run. And I think it because of all the shared state, and stuff calling other stuff internally. While not Stampit's fault, I do think it enables this pattern to easily.