SimenB / stylint

Improve your Stylus code with Stylint
https://simenb.github.io/stylint/
GNU General Public License v2.0
348 stars 62 forks source link

Rename reported error message properties #366

Closed wojciechczerniak closed 7 years ago

wojciechczerniak commented 7 years ago

Instead of lineNo we could use line and instead of col use column. I won't say that we should copy ESLint in everything but it's how they named them 😄 We can name them lineNo and columnNo/colNo but be consistent.

SimenB commented 7 years ago

I totally agree. I was just about to create an issue about the structure of the object passed to reporters.

We should copy this: http://eslint.org/docs/developer-guide/nodejs-api#executeonfiles

I'm just about done removing this from reporter.js. Expanding that code to handle a better format would simplify it even more

SimenB commented 7 years ago

I've started on this: https://github.com/SimenB/stylint/tree/restructur-message-obj

Going OK; making the transformation in done. Have to write tests for it, plus update tests for reporter. But the implementations should be done