search

SimenB / stylint

Improve your Stylus code with Stylint
https://simenb.github.io/stylint/
GNU General Public License v2.0
348 stars 62 forks source link

Banned functions #379

Closed dristic closed 7 years ago

dristic commented 7 years ago

This includes the rename fix for banned functions. The function is now called bannedFunctions everywhere.

@SimenB I could not find a branch called develop in the repository so this is against master. Maybe you have to push your develop branch?

Thanks!

SimenB commented 7 years ago

I dropped the develop branch approach, that's why you can't find it 😄

SimenB commented 7 years ago

@dristic I can cherry pick it over into v2 myself if you don't want to, but at least make the 2 code changes 😄

dristic commented 7 years ago

Sounds good, let me make the changes and re-push.

SimenB commented 7 years ago

LGTM, thanks!

SimenB commented 7 years ago

@dristic Merged as https://github.com/SimenB/stylint/commit/4a6ff755279bbe119a9e8c94681ab7c7572b5382

SimenB commented 7 years ago

Your GH user didn't get credit for the commit since you haven't added you email to your account

image

dristic commented 7 years ago

Ah oh well. I'm using the wrong e-mail with this account. Maybe next time!

SimenB commented 7 years ago

@dristic My fault for forgetting, but could you update the README with the new option?

Make sure to branch from v2 😄