search

SimenB / stylint

Improve your Stylus code with Stylint
https://simenb.github.io/stylint/
GNU General Public License v2.0
348 stars 62 forks source link

[WIP] Make use of glob utils from eslint #384

Open SimenB opened 7 years ago

SimenB commented 7 years ago

Ref #381

Need to add test for this, pushing to show progress

/cc @hermith @wojciechczerniak

SimenB commented 7 years ago

@wojciechczerniak @rossPatton A problem with this is that the eslint extraction is node 4+. Would have to update the code to work with node 0.10. Alternatively land this just on v2, but that would mean it'd be some time before it's available to consumers. On the other hand, this bug as probably existed for a long time without anyone noticing...

Thoughts?

EDIT: Even making the syntax valid causes it to fail tests because of something deep in shelljs

sigorilla commented 7 years ago

@SimenB Hi!

I set up some git hooks for my project and I don't want to run stylint for all files, only for changed files. So it would be nice to fix this bug, but also save the node 0.10+ :)

michalsindelar commented 7 years ago

@sigorilla You can run stylint only on staged files via a bit ugly command e.g. for f in $(./node_modules/.bin/staged-files); do ./node_modules/.bin/stylint --reporter stylint-stylish $f; done

SimenB commented 7 years ago

@sigorilla This is moving slower than I'd like to, and I apologize for that. This won't be fixed for v1, though. Node <4 is EOL now, so I won't spend any time supporting the old versions, sorry.