Should we add package-lock.json to .gitignore?

SimenB / stylint

Improve your Stylus code with Stylint

https://simenb.github.io/stylint/

GNU General Public License v2.0

348 stars 61 forks source link

Should we add package-lock.json to .gitignore? #428

Closed PalleZingmark closed 6 years ago

PalleZingmark commented 6 years ago

Since node 8 and npm 5, npm install creates a package-lock.json to lock the versions of dependencies that are installed. They recommend to commit this file, and that's what I usually do in normal projects when using NPM, but I think we should gitignore it in stylint as this will allow us to always test the latest version of the dependencies.

SimenB commented 6 years ago

PR welcome 🙂

V2 branch uses yarn, FWIW