chore: Update various dependencies

[Trott]

Update dev dependencies:

• istanbul 0.4.3 -> 0.4.5
• jsdoc 3.4.2 -> 3.6.2
• mocha 2.5.3 -> 6.1.4

Update dependency:

• chokidar 1.5.2 -> 3.0.2

The mocha udpate required a small change to the test file as mocha no longer forces an exit once all tests have passed. So a file had to be unwatched after the relevant test passed, or otherwise mocha would not exit.

These updates resolve all warnings from npm audit on a fresh clone of the repository.

[Trott]

Hmmm.... worked for me locally but failed even on Node.js 12.6.0 (which is what I was using locally) on Travis.... Guess I need to look more closely....

[ghaschel]

Please, correct me if I'm wrong, but it seems to me that travis is breaking because it is set to use some really old node versions:

• 4 - 2015
• 0.12 - 2015
• 0.10 - 2013

I'd change travis.yml node_js entry to something like this

• 6 - 2016
• 8 - 2017
• 10 - 2018
• 12 - 2019

[Trott]

Please, correct me if I'm wrong, but it seems to me that travis is breaking because it is set to use some really old node versions:

• 4 - 2015
• 0.12 - 2015
• 0.10 - 2013

I'd change travis.yml node_js entry to something like this

• 6 - 2016
• 8 - 2017
• 10 - 2018
• 12 - 2019

It broke on Node.js 12.x on Travis too, although not for me locally. https://travis-ci.org/SimenB/stylint/jobs/557142681

Changing .travis.yml would be contingent on the maintainers being OK with dropping support for those older versions.

[SimenB]

This module isn't really maintained. Happy to drop all EOL versions of node and release a major, though

[ghaschel]

Lol It doesn't even make sense what I said up there with the log you linked me, I must have seen a log from another place. Sorry for that.

I downloaded @Trott repository and can confirm that the tests don't fail for me as well.

[SimenB]

@Trott I merged #451 which updates some of the deps and drops older nodes. Would you be able to investigate the failing CI? It fails the same way for me locally (although it doesn't hang...)

[Trott]

@Trott I merged #451 which updates some of the deps and drops older nodes. Would you be able to investigate the failing CI? It fails the same way for me locally (although it doesn't hang...)

Rebased and force-pushed. Still fails, but I'll take a look....

[Trott]

Got rid of the unhandled promise rejection warnings (which were caused by calling chokidar.watch() with an empty or non-string path).

Used --exit with mocha to preserve the mocha 2.x behavior of exiting even when the tests are done even if there's stuff keeping the event loop open.

I think this should be passing now.

[Trott]

Travis is green! 🎉

[SimenB]

@Trott do you want this released?

[brwnrclse]

I'd appreciate a release! :) If you're referring to a new release on npm, otherwise just ignore me.

[SimenB]

Cool, 2.0.0 published 🙂