SimenB / stylint

Improve your Stylus code with Stylint
https://simenb.github.io/stylint/
GNU General Public License v2.0
348 stars 61 forks source link

bug(duplicates): false positives, if exists comments for Stylus selectors #457

Open Kristinita opened 5 years ago

Kristinita commented 5 years ago

1. Summary

If I use comments for Stylus selectors, I get:

duplicates error duplicate property or selector, consider merging

2. Data

2.1. Environment

3. Files

p
    // Comment
    // Another comment
    font-size 1.9375rem
    font-style italic

div
    // Kira
    // Goddess!
    font-size 1.3rem
    font-style italic

I couldn't find, that such comments are prohibited in Stylus.

{
    "colons": {
        "expect": "never",
        "error": true
    },
    "duplicates": {
        "expect": "always",
        "error": true
    }
}

4. Steps to reproduce

stylint Kira--Stylint-comments.styl

5. Actual behavior

If comments in Kira--Stylint-comments.styl exists:

D:\Kira--Stylint-comments.styl
10 duplicates error duplicate property or selector, consider merging

D:\Kira--Stylint-comments.styl
11 duplicates error duplicate property or selector, consider merging

Stylint: 2 Errors.
Stylint: 0 Warnings.

6. Expected behavior

Else I strip comments:

p
    font-size 1.9375rem
    font-style italic

div
    font-size 1.3rem
    font-style italic

No warnings or errors.

Thanks.

amitYadavDev commented 4 years ago

Hi @Kristinita, i m going to work on this issue.