SimformSolutionsPvtLtd / SSCustomBottomNavigation

Animated TabBar with native control and Jetpack Navigation support..βœ¨πŸ”–πŸš€
Apache License 2.0
508 stars 45 forks source link

BottomNav - Change Icons #11

Closed ayushmaniac closed 4 years ago

ayushmaniac commented 4 years ago

What if someone wants to change the image itself @bottomnav, you are only changing the color. How do one change the image of it. As well how is fragment going to get added?

shwetachauhan-simform commented 4 years ago

@ayushmaniac : You can add image from your main class, it's not static. I think you can find this in our demo. Let us know if you still have query. Also, We will update our demo so that you can check how we can add fragment.

ayushmaniac commented 4 years ago

@shwetachauhan-simform this is pretty awesome, just wanted to know how are we adding the fragments.

ShwetaChauhan18 commented 4 years ago

@ayushmaniac : We will update demo very soon. Please give star if it’s useful to you or if you like it.

ayushmaniac commented 4 years ago

tried doing this way to change the icons on setShowListener, didn't work

var bottom = bottomNavigationView.getModelById(id)
                bottom?.apply {
                    icon = drawable
                }
shwetachauhan-simform commented 4 years ago

@ayushmaniac : https://github.com/simformsolutions/SSCustomBottomNavigation/blob/master/app/src/main/java/com/sscustombottomnavigation/MainActivity.kt

Please check this and on line no 30 you can see we added drawable icon, you can change it there.

ayushmaniac commented 4 years ago

@shwetachauhan-simform that is a defined drawable for unselected items I guess, I wanted to change the icon when users clicks any menu.

shwetachauhan-simform commented 4 years ago

ohh, I see. That part is not implemented.

Thanks for update. We will add this.

shwetachauhan-simform commented 4 years ago

@ayushmaniac : We can add but it will take sometime , would be great if you can send us pr for this , I'll merge it.

ayushmaniac commented 4 years ago

@ShwetaChauhan18 @shwetachauhan-simform started working on that, just wanted to know with the bumps it has a background on the back which is a bit more than the height of the bump, how to remove it or keep it transparent?

Screenshot 2020-06-05 at 11 55 25 AM
ayushmaniac commented 4 years ago

@shwetachauhan-simform can you explain me the above mentioned

shwetachauhan-simform commented 4 years ago

Can you please add screen shot for that? I will check it and update you by tomorrow

Get Outlook for iOShttps://aka.ms/o0ukef


From: ayushmaniac notifications@github.com Sent: Friday, June 5, 2020 10:03:59 PM To: simformsolutions/SSCustomBottomNavigation SSCustomBottomNavigation@noreply.github.com Cc: Shweta Chauhan shweta.c@simformsolutions.com; Mention mention@noreply.github.com Subject: Re: [simformsolutions/SSCustomBottomNavigation] BottomNav - Change Icons (#11)

@shwetachauhan-simformhttps://github.com/shwetachauhan-simform can you explain me the above mentioned

β€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/simformsolutions/SSCustomBottomNavigation/issues/11#issuecomment-639615294, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APA7DUQCMGV2EMKHRBIIXKTRVEM7PANCNFSM4NRVE7FQ.

ayushmaniac commented 4 years ago

@shwetachauhan-simform already added screenshot, check the above mentioned point.

ayushmaniac commented 4 years ago

@shwetachauhan-simform any luck?