Overriding the theme makes little sense, not inheriting from the application theme does not either. The current behavior of the form widget is to recreate a theme from scratch by using the current primary color, which discards other aspects of the application theme. In doing so that widget requires input decorators to be passed into the form widget which is not needed.
This PR removes the Theme override in the form widget, which allows to keep inheriting from the app theme.
If someone wants a theme to differ from the original application theme they can do so with the standard mechanism of wrapping this widget outside the package with a Theme widget instead of being locked by this package which does not actually inherit the application theme (only a variant of the primary color).
This also mean that all the input decorations are not needed anymore, except if someone would like to style one individual input, which I doubt is a coherent use case. I let those field so this is not a breaking change and outside the scope of this PR.
Overriding the theme makes little sense, not inheriting from the application theme does not either. The current behavior of the form widget is to recreate a theme from scratch by using the current primary color, which discards other aspects of the application theme. In doing so that widget requires input decorators to be passed into the form widget which is not needed.
This PR removes the
Themeoverride in the form widget, which allows to keep inheriting from the app theme.If someone wants a theme to differ from the original application theme they can do so with the standard mechanism of wrapping this widget outside the package with a
Themewidget instead of being locked by this package which does not actually inherit the application theme (only a variant of the primary color).This also mean that all the input decorations are not needed anymore, except if someone would like to style one individual input, which I doubt is a coherent use case. I let those field so this is not a breaking change and outside the scope of this PR.